fix(sdk): createLink hook error dom attr rel

module-federation · Jan 27, 2025 · 3f532ca · 3f532ca
1 parent f141396
commit 3f532ca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/fair-lies-move.md b/.changeset/fair-lies-move.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/sdk': patch
+---
+
+fix(sdk): createLink hook error dom attr rel
diff --git a/packages/sdk/src/dom.ts b/packages/sdk/src/dom.ts
@@ -1,4 +1,4 @@
-import { CreateScriptHookDom, CreateScriptHookReturnDom } from './types';
+import type { CreateScriptHookDom, CreateScriptHookReturnDom } from './types';
 import { warn } from './utils';
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export async function safeWrapper<T extends (...args: Array<any>) => any>(
@@ -155,11 +155,11 @@ export function createLink(info: {
   for (let i = 0; i < links.length; i++) {
     const l = links[i];
     const linkHref = l.getAttribute('href');
-    const linkRef = l.getAttribute('ref');
+    const linkRel = l.getAttribute('rel');
     if (
       linkHref &&
       isStaticResourcesEqual(linkHref, info.url) &&
-      linkRef === info.attrs['ref']
+      linkRel === info.attrs['rel']
     ) {
       link = l;
       needAttach = false;