Omorphia 0.6 #816
Closed
Omorphia 0.6 #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToBinio
force-pushed
the
omorphia-0.6
branch
from
4cf58fd to
8a3876f
Compare
ToBinio
force-pushed
the
omorphia-0.6
branch
2 times, most recently
from
18b7d8b to
17610fc
Compare
brawaru
reviewed
Nov 17, 2023
theseus_gui/src/main.js
Outdated
Comment on lines
32
to
36
| // Sanity check that we indeed have this locale's definition. | ||
| // | ||
| // Because it would be a shame if some person called "Brawaru" tried to like, use | ||
| // console to add a custom locale for testing purposes, and that locale never actually | ||
| // existed in Omorphia. A big big shame. |
There was a problem hiding this comment.
You didn't really need to copy all of these comments from the example 😂 They were just to describe the train of thought that went into writing the example, in case someone else may spot any mistakes or come up with a better idea how some things can be implemented. The code should still be pretty clear without most of them 🙂
There was a problem hiding this comment.
tbh i was just happy that it compiled again
removed most(probably to many) comments
|
0.7 isn't ready for Theseus, major design changes are coming in that version. We have plans to do a design refresh on Theseus once those changes are done. For now, theseus shouldn't go past 0.6.x |
ToBinio
force-pushed
the
omorphia-0.6
branch
from
17610fc to
375122a
Compare
|
thanks for the information |
ToBinio
force-pushed
the
omorphia-0.6
branch
from
375122a to
0b66b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Omorphia dependency to 0.6
changes
class="r-btn"where necessaryvintl(based on brawaru's tutorial)note:
sry for the one big PR, but most of the changes need to happen simultaneously
maybe you need to delete the
node_modulesfolder and reinstall all (pnpm had some problems in my case)