feat(labrinth): environment variables for more customizable SMTP #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help setting up labrinth for local development. You can now use a mock SMTP server such as smtp4dev. The TLS options will stay the same as before if set to `true`, and disabled when `false`. Depends on modrinth#2883
Erb3
changed the title
Erb3
changed the title
|
Prioritizing this over #2883, making that one a draft and removing dependency on it due to conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two new environment variables,
SMTP_PORTandSMTP_TLS. SMTP refers the protocol used to send emails.SMTP_PORTconfigures which port to connect to on the SMTP server. It defaults to the standard and old default,25.SMTP_TLSis a boolean that defines if TLS security should be required to connect to the server. This defaults to the old value,true. Implementation wise I've copied the default values from thelettrecrate we are using if the setting is enabled. This is how it behaved before, as we did not specify a TLS setting. If it is set tofalseit will instead useTls::None.This will help setting up labrinth for local development. You can use a mock SMTP server such as smtp4dev without setting up certificates and such.