Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove white flash when starting app #1155

Closed
wants to merge 1 commit into from

Conversation

ToBinio
Copy link
Contributor

@ToBinio ToBinio commented Apr 27, 2024

This PR should remove all the white flashes happening when starting the app. Not sure if they happened on all platforms but at least on Linux - Wayland they did.

The app only gets shown after the first render happened. This was kinda already done but it seems like the window was shown too early and the Tauri setting didn't work (at least on linux) so I had to hide it by hand.

    "windows": [
      {
        "titleBarStyle": "Overlay",
        "hiddenTitle": true,
        "fullscreen": false,
        "height": 800,
        "resizable": true,
        "title": "Modrinth App",
        "width": 1280,
        "minHeight": 700,
        "minWidth": 1100,
        "visible": false, // <- this should have hidden the window already
        "decorations": false
      }
    ]

the second fix was moving the isLoading.value = false in vue after the initialization code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants