Auth retrying, std logs #971
thesuzerain
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
4 warnings
|
unnecessarily eager cloning of iterator items:
theseus_cli/src/subcommands/profile.rs#L179
warning: unnecessarily eager cloning of iterator items
--> theseus_cli/src/subcommands/profile.rs:179:17
|
179 | loaders.iter().cloned().find(filter).ok_or_else(|| {
| ^^^^^^^^^^^^^^----------------------
| |
| help: try: `.find(|&x| filter(x)).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `#[warn(clippy::iter_overeager_cloned)]` on by default
|
|
the borrowed expression implements the required traits:
theseus/src/launcher/mod.rs#L180
warning: the borrowed expression implements the required traits
--> theseus/src/launcher/mod.rs:180:27
|
180 | &io::canonicalize(&profile.get_profile_full_path().await?)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `profile.get_profile_full_path().await?`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
unnecessarily eager cloning of iterator items:
theseus/src/api/profile/create.rs#L273
warning: unnecessarily eager cloning of iterator items
--> theseus/src/api/profile/create.rs:273:26
|
273 | let loader_version = loaders
| ___________________________^
274 | | .iter()
| | ________________-
275 | || .cloned()
276 | || .find(filter)
| ||_____________________^
| |_____________________|
| help: try: `.find(|&x| filter(x)).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `#[warn(clippy::iter_overeager_cloned)]` on by default
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|