Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of new Markdown section in Writing #122

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

SaintRod
Copy link
Contributor

Hi, all.

I am submitting a proposed revision to the Writing section based on issue #118.

This PR introduces a new sub-section in Writing called Markdown that is comprised of two parts:

  • Plain Text Markdown
  • Quarto

A new section was needed as markdown files (Quarto included) are not typically the final product - unlike notebooks which are commonly standalone products.

@gdalle
Copy link
Collaborator

gdalle commented Aug 1, 2024

Thank you for this contribution! I'll take a look next week, don't hesitate to ping me if I forget 😉

Copy link
Collaborator

@adrhill adrhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR!

I think we can assume some familiarity with Markdown from users, since it is used in Julia docstrings, Jupyter and Pluto notebooks.
I would therefore suggest to trim the added contents down a little bit.

writing/index.md Outdated Show resolved Hide resolved
writing/index.md Outdated Show resolved Hide resolved
writing/index.md Outdated Show resolved Hide resolved
writing/index.md Outdated Show resolved Hide resolved
writing/index.md Show resolved Hide resolved
writing/index.md Outdated Show resolved Hide resolved
@SaintRod
Copy link
Contributor Author

@adrhill updated! Please review again and let me know if further revisions are required

@adrhill
Copy link
Collaborator

adrhill commented Aug 25, 2024

Looks good to me, thanks!
I'll have @gdalle merge this one so we get feedback from a second person.

@adrhill adrhill requested a review from gdalle August 25, 2024 19:31
Copy link
Collaborator

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@gdalle gdalle merged commit c06b830 into modernjuliaworkflows:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants