Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwitchCase 하위 타입스크립트/리액트 버전 타입 호환성을 위해 반환 타입 수정 #677

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

ssi02014
Copy link
Contributor

Overview

  • SwitchCase 하위 타입스크립트/리액트 버전 타입 호환성을 위해 반환 타입 수정
  • 관심사 분리를 위해 formatNumberWithUnits에서 콤마 기능 제거 및 소수점 처리 개선

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

@ssi02014 ssi02014 added @modern-kit/react @modern-kit/react @modern-kit/utils @modern-kit/utils fix 버그 수정 및 코드 개선 labels Jan 13, 2025
@ssi02014 ssi02014 self-assigned this Jan 13, 2025
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: e84a453

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@modern-kit/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.21%. Comparing base (33cf068) to head (e84a453).
Report is 155 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   97.41%   98.21%   +0.79%     
==========================================
  Files         164      179      +15     
  Lines        1470     1568      +98     
  Branches      361      410      +49     
==========================================
+ Hits         1432     1540     +108     
+ Misses         34       26       -8     
+ Partials        4        2       -2     
Components Coverage Δ
@modern-kit/react 96.95% <ø> (+1.73%) ⬆️
@modern-kit/utils 99.59% <ø> (-0.41%) ⬇️

@ssi02014 ssi02014 merged commit 41a4223 into main Jan 13, 2025
3 checks passed
@ssi02014 ssi02014 deleted the fix/react2 branch January 13, 2025 11:17
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 및 코드 개선 @modern-kit/react @modern-kit/react @modern-kit/utils @modern-kit/utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant