Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): 불 필요한 useAsyncPreservedCallback 제거 및 usePreservedCallback 문서 개선 #626

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Dec 9, 2024

Overview

usePreservedCallback으로도 비동기 콜백 함수를 잘 다룰 수 있기 때문에 useAsyncPreservedCallback를 제거합니다.

const preservedCallback = usePreservedCallback(async () => { /* ... */});

await preservedCallback();

usePreservedCallback의 문서를 개선 및 한글화를 진행합니다.

추가적으로
react v19 안정화 버전이 공식 릴리즈 됨에 따라 react peerDependency 버전 명시를 수정합니다.

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: bbca7be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@modern-kit/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ssi02014 ssi02014 force-pushed the fix/react branch 2 times, most recently from 27c30dc to f60fcf6 Compare December 9, 2024 05:23
@ssi02014 ssi02014 self-assigned this Dec 9, 2024
@ssi02014 ssi02014 added documentation 문서 추가 및 수정 @modern-kit/react @modern-kit/react fix 버그 수정 및 코드 개선 labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (33cf068) to head (bbca7be).
Report is 116 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   97.41%   98.31%   +0.89%     
==========================================
  Files         164      172       +8     
  Lines        1470     1542      +72     
  Branches      361      397      +36     
==========================================
+ Hits         1432     1516      +84     
+ Misses         34       24      -10     
+ Partials        4        2       -2     
Components Coverage Δ
@modern-kit/react 97.14% <ø> (+1.93%) ⬆️
@modern-kit/utils 99.59% <ø> (-0.41%) ⬇️

@ssi02014 ssi02014 merged commit 889289c into main Dec 9, 2024
3 checks passed
@ssi02014 ssi02014 deleted the fix/react branch December 9, 2024 05:30
@github-actions github-actions bot mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 문서 추가 및 수정 fix 버그 수정 및 코드 개선 @modern-kit/react @modern-kit/react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant