New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODELIX-724: stabilize plugin GUI #73

Merged

benedekh merged 14 commits into main from feature/modelix-724

Apr 22, 2024

Contributor

benedekh commented Mar 21, 2024

Fixes MODELIX-724

benedekh requested review from odzhychko and KarstenDiekhoff

March 21, 2024 09:28

benedekh self-assigned this

odzhychko reviewed

View reviewed changes

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/gui/ModelSyncGuiFactory.kt Outdated Show resolved Hide resolved

benedekh requested review from odzhychko and slisson

March 26, 2024 07:56

benedekh marked this pull request as draft

March 26, 2024 09:10

benedekh added 3 commits

March 26, 2024 11:41


          fix(mps-sync-plugin): stabilize plugin GUI (MODELIX-724)

24cba73


          feat(mps-sync-plugin-lib): support ReferenceLinkFromName as Resolvabl…

98cb4a0

…eReference input


          refactor(mps-sync-plugin): use Modelql to fetch root-level modules

bfe5179

benedekh force-pushed the feature/modelix-724 branch from d4bb450 to bfe5179 Compare

March 26, 2024 12:00

benedekh marked this pull request as ready for review

March 26, 2024 12:01

benedekh removed the request for review from KarstenDiekhoff

March 26, 2024 12:03


          fix(mps-sync-plugin-lib): replace completedFuture(null) with default …

e0ad4e5

…completion value

odzhychko reviewed

View reviewed changes

mps-sync-plugin-lib/src/main/kotlin/org/modelix/mps/sync/bindings/ModelBinding.kt Show resolved Hide resolved

odzhychko reviewed

View reviewed changes

mps-sync-plugin-lib/src/main/kotlin/org/modelix/mps/sync/mps/factories/SNodeFactory.kt Outdated Show resolved Hide resolved

odzhychko reviewed

View reviewed changes

mps-sync-plugin-lib/src/main/kotlin/org/modelix/mps/sync/mps/factories/SNodeFactory.kt Outdated Show resolved Hide resolved

odzhychko reviewed

View reviewed changes

...n/kotlin/org/modelix/mps/sync/transformation/modelixToMps/initial/ITreeToSTreeTransformer.kt Outdated Show resolved Hide resolved

odzhychko reviewed

View reviewed changes

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/ModelSyncService.kt Outdated Show resolved Hide resolved

odzhychko suggested changes

View reviewed changes

mps-sync-plugin-lib/src/main/kotlin/org/modelix/mps/sync/SyncServiceImpl.kt Show resolved Hide resolved

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/gui/ModelSyncGuiFactory.kt Outdated Show resolved Hide resolved

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/gui/ModelSyncGuiFactory.kt Outdated Show resolved Hide resolved

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/gui/ModelSyncGuiFactory.kt Outdated Show resolved Hide resolved

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/gui/ModelSyncGuiFactory.kt Show resolved Hide resolved

odzhychko reviewed

View reviewed changes

mps-sync-plugin/src/main/kotlin/org/modelix/mps/sync/plugin/gui/ModelSyncGuiFactory.kt Outdated Show resolved Hide resolved

benedekh changed the title ~~fix(mps-sync-plugin): stabilize plugin GUI (MODELIX-724)~~ MODELIX-724: stabilize plugin GUI

benedekh and others added 8 commits

April 17, 2024 11:55


          fix(mps-sync-plugin): add more descriptive error message

3087efe

Co-authored-by: Oleksandr Dzhychko <oleksandr@dzhychko.de>


          refactor(mps-sync-plugin-lib): throw IllegalArgumentException instead…

3ded560

… of NPE

if reference has the wrong type


          feat(mps-sync-plugin-lib): add GeneratedReferenceLink as a possible I…

b79fb24

…ReferenceLink implementation


          refactor(mps-sync-plugin-lib): move the isModule check a bit above

c7fbe66


          refactor(mps-sync-plugin-lib): use 'null' as CF's default completion …

a7f49a6

…value


          refactor(mps-sync-plugin): do not maintain an internal list of active…

49ee4cd

… clients


          refactor(mps-sync-plugin): use ReentrantLock instead of handcrafted B…

c13ac8f

…oolean flag


          refactor(mps-sync-plugin): use Semaphone instead of ReentrantLock. Di…

71d44f0

…sable UI controls during action

benedekh requested a review from odzhychko

April 18, 2024 12:29

benedekh added 2 commits

April 22, 2024 10:18


          refactor(mps-sync-plugin-lib): IReferenceLink.getSimpleName() always …

1fdcf25

…exists


          refactor(mps-sync-plugin): use Mutex instead of Semaphore(1)

fefec27

odzhychko approved these changes

View reviewed changes

Contributor

odzhychko left a comment

I am still upset that nothing is automatically tested. This plugin will be difficult to maintain.

But I guess that is nothing that can be added now.

benedekh merged commit 13eab42 into main

10 checks passed

benedekh deleted the feature/modelix-724 branch

April 22, 2024 10:20

Member

slisson commented Apr 30, 2024

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

slisson added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels