Fixed binary compatibility issues between different MPS versions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same class files There were LinkageErrors thrown when running the plugin in a different MPS version than what was used during compilation. To ensure that the plugin is actually compatible to all MPS versions it is compiled twice and then the resulting jar file is checked to be identical. That check fails if some (Kotlin) API changed that compiles to different byte code.
To ensure the same plugin can be used in older MPS versions.
It produces the following compile error: Cannot inline bytecode built with JVM target 17 into bytecode that is being built with JVM target 11. Please specify proper '-jvm-target' option
slisson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mps-legacy-sync-plugin didn't work in all MPS versions, because of binary incompatibility of Kotlin APIs, which resulted in LinkageErrors at runtime. The project is now compiled twice, for the oldest and latest supported MPS version, and the resulting jar files are checked for diferences.
Required for MODELIX-672