Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke auth method #35

Open
pamelafox opened this issue May 29, 2012 · 2 comments
Open

Revoke auth method #35

pamelafox opened this issue May 29, 2012 · 2 comments

Comments

@pamelafox
Copy link

I added a revoke_auth method to the SDK, seems to work:

def revoke_auth(self, id):
    self.request(id + '/permissions', post_args={"method": "delete"})

Tried to do a pull request online but Github errored.

@martey
Copy link
Member

martey commented May 30, 2012

I think the error might be because of the additional changes you made to the error handling, which is similar but not the same as earlier commits (like bfbe593). If it was removed, the pull request might work properly.

Looking at the API documentation on the permissions connection, it looks like it is also possible to revoke specific permissions as well as deauthorizing the entire application. Could you extend your method to include this?

@seawolf42
Copy link
Contributor

I can add this functionality to #264 if you'd like, but I will need a suggestion on how to test it without changing the permissions of the user ID supplied for testing (so other tests continue to pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants