upgrade rust to 1.75.0 nightly - 2023-11-09

mobilecoinfoundation · Dec 10, 2024 · 17ee669 · 17ee669
1 parent da3b753
commit 17ee669
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/crypto/keys/src/ed25519.rs b/crypto/keys/src/ed25519.rs
@@ -3,10 +3,6 @@
 //! This module implements the common keys traits for the Ed25519 digital
 //! signature scheme.
 
-// skipping clippy check here because we're mapping errors.
-// Not sure if moving to 'from' will raise the kind of errors that we want.
-#![allow(clippy::unnecessary_fallible_conversions)]
-
 use crate::{
     DigestSigner, DigestVerifier, DistinguishedEncoding, KeyError, PrivateKey, PublicKey,
     SignatureEncoding, SignatureError, Signer, Verifier,
@@ -213,8 +209,7 @@ impl DistinguishedEncoding for Ed25519Public {
 
 impl<D: Digest<OutputSize = U64>> DigestVerifier<D, Ed25519Signature> for Ed25519Public {
     fn verify_digest(&self, digest: D, signature: &Ed25519Signature) -> Result<(), SignatureError> {
-        let sig =
-            DalekSignature::try_from(&signature.to_bytes()).map_err(|_e| SignatureError::new())?;
+        let sig = DalekSignature::from(&signature.to_bytes());
         self.0
             .verify_prehashed(digest, None, &sig)
             .map_err(|_e| SignatureError::new())
@@ -232,8 +227,7 @@ impl PublicKey for Ed25519Public {}
 
 impl Verifier<Ed25519Signature> for Ed25519Public {
     fn verify(&self, message: &[u8], signature: &Ed25519Signature) -> Result<(), SignatureError> {
-        let sig =
-            DalekSignature::try_from(&signature.to_bytes()).map_err(|_e| SignatureError::new())?;
+        let sig = DalekSignature::from(&signature.to_bytes());
         self.0
             .verify_strict(message, &sig)
             .map_err(|_e| SignatureError::new())
@@ -363,8 +357,7 @@ impl<D: Digest<OutputSize = U64>> DigestSigner<D, Ed25519Signature> for Ed25519P
 
 impl<D: Digest<OutputSize = U64>> DigestVerifier<D, Ed25519Signature> for Ed25519Pair {
     fn verify_digest(&self, digest: D, signature: &Ed25519Signature) -> Result<(), SignatureError> {
-        let sig =
-            DalekSignature::try_from(&signature.to_bytes()).map_err(|_e| SignatureError::new())?;
+        let sig = DalekSignature::from(&signature.to_bytes());
         self.0
             .verify_prehashed(digest, None, &sig)
             .map_err(|_e| SignatureError::new())
@@ -415,8 +408,7 @@ impl TryFrom<Vec<u8>> for Ed25519Pair {
 
 impl Verifier<Ed25519Signature> for Ed25519Pair {
     fn verify(&self, message: &[u8], signature: &Ed25519Signature) -> Result<(), SignatureError> {
-        let sig =
-            DalekSignature::try_from(&signature.to_bytes()).map_err(|_e| SignatureError::new())?;
+        let sig = DalekSignature::from(&signature.to_bytes());
         self.0
             .verifying_key()
             .verify_strict(message, &sig)