Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few updates #233

Merged
merged 2 commits into from
Sep 25, 2024
Merged

A few updates #233

merged 2 commits into from
Sep 25, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented May 31, 2024

I'm happy to finally get to integrate this awesome lib into flyxc.app thanks to @flyingtof

Ref vicb/flyXC#203

@mmomtchev
Copy link
Owner

is there any reason to do this?

@vicb
Copy link
Contributor Author

vicb commented Jun 3, 2024

Here are some reasons:

  • The .d.ts changes are needed to access the output of the optimizer
  • I find ?? more semantically correct than the hacky || which doesn't short-circuit on 0

@mmomtchev
Copy link
Owner

Your comment was simultaneous with this one:
mmomtchev/node-gdal-async#30

Normally, the same decision-making process applies, but since I won't have to make an announcement that someone contributed this change, I do not think it will have an effect on my situation. I will however make it very clear.

@vicb
Copy link
Contributor Author

vicb commented Jun 3, 2024

Hum, I'm sorry but I don't understand what you mean?
We just happened to comment at the same time and?

@mmomtchev
Copy link
Owner

Well, let me explain you a fundamental principle in criminal law called "proof beyond any reasonable doubt". Many people believe that DNA is an absolute proof. It is not - in fact there is a very small chance that two people can fully share the same DNA - without even being related. The chance is very small - it is on the scale of 1 to trillions. The subject has been studied extensively: The Evaluation of Forensic DNA Evidence - so that in these cases, the explanation that someone just happened to have the same DNA as the real killer does not stand in court.

In your case, barring an eventual activation of the Infinite Improbability Drive, this is absolutely the case.

In fact, since the police tried threatening me about 8 months ago, there hasn't been a single comment on any project I own that is not related to this affair

@vicb
Copy link
Contributor Author

vicb commented Jun 4, 2024

Ok, you're probably right.

I'm going to fork your project an make the fixes on my side - both the projects will share some DNA.

Meanwhile I have integrated your lib in a worker to isolate the global namespace pollution. It will be live in the planner of flyxc.app shortly.

Thanks for your work on igc-xc-score 🙏

@mmomtchev mmomtchev merged commit ac81c38 into mmomtchev:main Sep 25, 2024
3 checks passed
@vicb vicb deleted the branch branch September 25, 2024 07:52
@vicb
Copy link
Contributor Author

vicb commented Sep 25, 2024

Thanks @mmomtchev.

@flyingtof recently added track optimizations to flyxc, it's working very well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants