Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM action improvement #68

Merged
merged 4 commits into from
Feb 9, 2025
Merged

Conversation

anandhu-eng
Copy link
Contributor

Changes:

  1. The target items are not removed without user prompt until -f flag is provided by the user for force removal(wrt. Discussion: Safer to ask user confirmation for rm cache? #67).
  2. Add support to remove the entire cache folders with command: mlc rm cache

@anandhu-eng anandhu-eng requested a review from a team as a code owner February 9, 2025 04:02
Copy link

github-actions bot commented Feb 9, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng anandhu-eng marked this pull request as draft February 9, 2025 04:07
@anandhu-eng anandhu-eng marked this pull request as ready for review February 9, 2025 04:59
@anandhu-eng
Copy link
Contributor Author

anandhu-eng commented Feb 9, 2025

The failing GitHub action should pass after merging this PR.

@@ -1715,10 +1741,9 @@ def main():
res = method(run_args)
if res['return'] > 0:
logger.error(res.get('error', f"Error in {action}"))
raise Exception(f"""An error occurred {res}""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is removed?

@arjunsuresh arjunsuresh merged commit c23605a into mlcommons:dev Feb 9, 2025
29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants