Merge pull request #23 from AYastrebov/master

Make protocol methods optionsl
ml-opensource · Sep 29, 2017 · 5417bbd · 5417bbd
2 parents 510d959 + e64781a
commit 5417bbd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/Example/Cartfile b/Example/Cartfile
@@ -1 +1 @@
-github "nodes-ios/KeyboardHelper" "swift-3.0"
+github "nodes-ios/KeyboardHelper"
diff --git a/Example/Cartfile.resolved b/Example/Cartfile.resolved
@@ -1 +1 @@
-github "nodes-ios/KeyboardHelper" "58d7c2bf19f7bc93d733290f06ae0eedf03f18a5"
+github "nodes-ios/KeyboardHelper" "1.1.0"
diff --git a/KeyboardHelper/Classes/KeyboardHelper.swift b/KeyboardHelper/Classes/KeyboardHelper.swift
@@ -26,6 +26,11 @@ public protocol KeyboardHelperDelegate: class {
     func keyboardWillDisappear(_ info: KeyboardAppearanceInfo)
 }
 
+/// Hack to make protocol methods optional
+public extension KeyboardHelperDelegate {
+    func keyboardWillAppear(_ info: KeyboardAppearanceInfo) {}
+    func keyboardWillDisappear(_ info: KeyboardAppearanceInfo) {}
+}
 
 /// Useful helper to keep track of keyboard changes.
 public class KeyboardHelper {

diff --git a/KeyboardHelperTests/Tests/KeyboardHelperTests.swift b/KeyboardHelperTests/Tests/KeyboardHelperTests.swift
@@ -43,10 +43,6 @@ class HideSpyDelegate : KeyboardHelperDelegate {
         kai = info
         expectation.fulfill()
     }
-
-    func keyboardWillAppear(_ info: KeyboardAppearanceInfo) {
-
-    }
 }
 
 class KeyboardHelperTests: XCTestCase {
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		github "nodes-ios/KeyboardHelper" "swift-3.0"
		github "nodes-ios/KeyboardHelper"
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		github "nodes-ios/KeyboardHelper" "58d7c2bf19f7bc93d733290f06ae0eedf03f18a5"
		github "nodes-ios/KeyboardHelper" "1.1.0"