Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Match list #65

Open
mkoskim opened this issue Mar 10, 2023 · 0 comments
Open

Search: Match list #65

mkoskim opened this issue Mar 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mkoskim
Copy link
Owner

mkoskim commented Mar 10, 2023

Background

Many modern coding editors like Visual Code create a list of matches when searching. It is very handy! So, we need to implement similar.

Implementation

For right hand index, add a search match list as an option (in addition to body index).

If anyhow possible, it would be best to generate the search match list from the SlateJS editor decorations. We already use decorate() function, which generates an up-to-date list of matches to be highlighted. If we can access that and show it to user, our problems may be solved.

Possible idea

Add an arrow-left button to search box. Pressing it will take search box to body index menu, and replace body index with list of matches. Also, search box left arrow will be changed to right arrow, and pressing it will take search box back to editor menu, and show index menu.

@mkoskim mkoskim added the enhancement New feature or request label Mar 10, 2023
@mkoskim mkoskim added this to the Basic improvements milestone Mar 10, 2023
@mkoskim mkoskim changed the title Search match list Search: Match list Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

1 participant