Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build for 1.1.0 #58

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix Build for 1.1.0 #58

merged 1 commit into from
Jan 31, 2025

Conversation

mkasberg
Copy link
Owner

@mkasberg mkasberg commented Jan 31, 2025 •
edited
Loading

Ghostty 1.1.0 has moved the bzip2 dependency to SharedDeps.zig. Need to update our build script to handle that.

There are some other build errors with Ubuntu 22.04, let's remove that for now so we don't delay releasing this for 24.04+.

@mkasberg mkasberg force-pushed the 1-1-build branch 2 times, most recently from f1b1e72 to a9a5e3d Compare January 31, 2025 14:25
@mkasberg
Fix Build for 1.1.0
ae89221 
Ghostty 1.1.0 has moved the bzip2 dependency to SharedDeps.zig. Need to
update our build script to handle that.

There are some other build errors with Ubuntu 22.04, let's remove that
for now so we don't delay releasing this for 24.04+.
@mkasberg mkasberg merged commit da597d8 into main Jan 31, 2025
7 checks passed
@mkasberg mkasberg deleted the 1-1-build branch January 31, 2025 14:51
@fdellwing
Copy link

I was able to build it for 22.04 without any changes, that is strange..

❯ docker build -t ghostty:ubuntu-22.04-amd64 .
[+] Building 280.6s (9/9) FINISHED                                                                                                                                                                                            docker:default
 => [internal] load .dockerignore                                                                                                                                                                                                       0.1s
 => => transferring context: 2B                                                                                                                                                                                                         0.0s
 => [internal] load build definition from Dockerfile                                                                                                                                                                                    0.1s
 => => transferring dockerfile: 1.18kB                                                                                                                                                                                                  0.0s
 => [internal] load metadata for docker.io/library/ubuntu:24.10                                                                                                                                                                         1.6s
 => [1/5] FROM docker.io/library/ubuntu:24.10@sha256:102bc1874fdb136fc2d218473f03cf84135cb7496fefdb9c026c0f553cfe1b6d                                                                                                                   2.9s
 => => resolve docker.io/library/ubuntu:24.10@sha256:102bc1874fdb136fc2d218473f03cf84135cb7496fefdb9c026c0f553cfe1b6d                                                                                                                   0.0s
 => => sha256:102bc1874fdb136fc2d218473f03cf84135cb7496fefdb9c026c0f553cfe1b6d 6.69kB / 6.69kB                                                                                                                                          0.0s
 => => sha256:fad5ba7223f8d87179dfa23211d31845d47e07a474ac31ad5258afb606523c0d 424B / 424B                                                                                                                                              0.0s
 => => sha256:e40b6e31bd8cba664c267ee7a21689b1f98585818942761ff1cb8cd3c2df323d 2.30kB / 2.30kB                                                                                                                                          0.0s
 => => sha256:31734b193a814b7d6f96f0d11a89c942ca61ac79d819105323c548bf31f98613 30.60MB / 30.60MB                                                                                                                                        1.1s
 => => extracting sha256:31734b193a814b7d6f96f0d11a89c942ca61ac79d819105323c548bf31f98613                                                                                                                                               1.5s
 => [2/5] RUN DEBIAN_FRONTEND="noninteractive" apt-get -qq update &&     apt-get -qq -y install     build-essential     libbz2-dev     libonig-dev     lintian     lsb-release     pandoc     wget                                    142.8s
 => [3/5] RUN wget -q "https://github.com/jedisct1/minisign/releases/download/0.11/minisign-0.11-linux.tar.gz" &&     tar -xzf minisign-0.11-linux.tar.gz &&     mv "minisign-linux/$(uname -m)/minisign" /usr/local/bin &&     rm -r   1.4s
 => [4/5] RUN wget -q "https://ziglang.org/download/0.13.0/zig-linux-$(uname -m)-0.13.0.tar.xz" &&     tar -xf "zig-linux-$(uname -m)-0.13.0.tar.xz" -C /opt &&     rm "zig-linux-$(uname -m)-0.13.0.tar.xz" &&     ln -s "/opt/zig-li  5.2s
 => [5/5] RUN DEBIAN_FRONTEND="noninteractive" apt-get -qq update &&     apt-get -qq -y install     libadwaita-1-dev     libgtk-4-dev                                                                                                 123.3s
 => exporting to image                                                                                                                                                                                                                  3.3s
 => => exporting layers                                                                                                                                                                                                                 3.3s
 => => writing image sha256:81737df9adfb5e268f24fcf4ef23fcb409f8aa4e2bf8a10382aab812d88b5c99                                                                                                                                            0.0s
 => => naming to docker.io/library/ghostty:ubuntu-22.04-amd64                                                                                                                                                                           0.0s

What's Next?
  1. Sign in to your Docker account → docker login
  2. View a summary of image vulnerabilities and recommendations → docker scout quickview
❯ docker run --rm -v$PWD:/workspace -w /workspace ghostty:ubuntu-22.04-amd64 /bin/bash build-ghostty.sh
Signature and comment signature verified
Trusted comment: timestamp:1738273632   file:ghostty-1.1.0.tar.gz       hashed
1220dd654ef941fc76fd96f9ec6adadf83f69b9887a0d3f4ee5ac0a1a3e11be35cf5
12207b7a5b538ffb7fb18f954ae17d2f8490b6e3778a9e30564ad82c58ee8da52361
Build Summary: 78/78 steps succeeded
install success
+- install generated to share/ghostty/doc/ghostty.1.md success
|  +- run mdgen_ghostty_1 success 24ms MaxRSS:4M
|     +- zig build-exe mdgen_ghostty_1 Debug native success 15s MaxRSS:268M
|        +- run helpgen success 140ms MaxRSS:4M
|        |  +- zig build-exe helpgen Debug native success 23s MaxRSS:333M
|        |     +- options success
|        +- run helpgen (+1 more reused dependencies)
|        +- options success
+- install generated to share/ghostty/doc/ghostty.1.html success
|  +- run pandoc success 1s MaxRSS:126M
|     +- run mdgen_ghostty_1 (+1 more reused dependencies)
+- install generated to share/man/man1/ghostty.1 success
|  +- run pandoc success 1s MaxRSS:128M
|     +- run mdgen_ghostty_1 (+1 more reused dependencies)
+- install generated to share/ghostty/doc/ghostty.5.md success
|  +- run mdgen_ghostty_5 success 59ms MaxRSS:4M
|     +- zig build-exe mdgen_ghostty_5 Debug native success 17s MaxRSS:280M
|        +- run helpgen (+1 more reused dependencies)
|        +- run helpgen (+1 more reused dependencies)
|        +- options success
+- install generated to share/ghostty/doc/ghostty.5.html success
|  +- run pandoc success 2s MaxRSS:150M
|     +- run mdgen_ghostty_5 (+1 more reused dependencies)
+- install generated to share/man/man5/ghostty.5 success
|  +- run pandoc success 1s MaxRSS:128M
|     +- run mdgen_ghostty_5 (+1 more reused dependencies)
+- install ghostty success
|  +- zig build-exe ghostty ReleaseFast native-native success 1m MaxRSS:653M
|     +- options success
|     +- zig build-lib glslang ReleaseFast native-native success 1m MaxRSS:364M
|     +- WriteFile  success
|     +- zig build-lib spirv_cross ReleaseFast native-native success 1m MaxRSS:749M
|     +- WriteFile  success
|     +- zig build-lib simdutf ReleaseFast native-native success 56s MaxRSS:257M
|     +- WriteFile  success
|     +- run gbp (gbp.bin.z) success 6s MaxRSS:4M
|     |  +- zig build-exe gbp Debug native success 10s MaxRSS:214M
|     +- run dwp (dwp.bin.z) success 2s MaxRSS:9M
|     |  +- zig build-exe dwp Debug native success 12s MaxRSS:206M
|     |     +- options success
|     +- zig build-lib cimgui ReleaseFast native-native success 54s MaxRSS:229M
|     +- WriteFile  success
|     +- zig build-lib highway ReleaseFast native-native success 38s MaxRSS:363M
|     +- WriteFile hwy success
|     +- zig build-lib utfcpp ReleaseFast native-native success 207ms MaxRSS:57M
|     +- WriteFile  success
|     +- run zig-wayland-scanner (wayland.zig) success 35ms MaxRSS:4M
|     |  +- zig build-exe zig-wayland-scanner Debug native success 19s MaxRSS:233M
|     +- run glib-compile-resources (ghostty_resources.c) success 664ms MaxRSS:7M
|     |  +- WriteFile gresource.xml success
|     +- run glib-compile-resources (ghostty_resources.h) success 11ms MaxRSS:6M
|     |  +- WriteFile gresource.xml (reused)
|     +- run helpgen (+1 more reused dependencies)
|     +- run helpgen (+1 more reused dependencies)
|     +- run unigen success 7s MaxRSS:4M
|     |  +- zig build-exe unigen Debug native success 14s MaxRSS:207M
|     +- run unigen (+1 more reused dependencies)
+- make share/terminfo directory success 1ms MaxRSS:3M
+- copy terminfo db success 2ms MaxRSS:3M
|  +- tic (terminfo) success 2ms MaxRSS:3M
|  |  +- WriteFile ghostty.terminfo success
|  +- make share/terminfo directory (reused)
+- install src/shell-integration/ success
+- install dependency/ success
+- install generated/ success
|  +- WriteFile ghostty.fish success
+- install generated/ success
|  +- WriteFile _ghostty success
+- install generated/ success
|  +- WriteFile ghostty.bash success
+- install generated/ success
|  +- WriteFile syntax/ghostty.vim success
+- install generated/ success
|  +- WriteFile syntax/ghostty.vim cached
+- install generated/ success
|  +- WriteFile ghostty.sublime-syntax success
+- install dist/linux/app.desktop to share/applications/com.mitchellh.ghostty.desktop success
+- install dist/linux/ghostty_dolphin.desktop to share/kio/servicemenus/com.mitchellh.ghostty.desktop success
+- install dist/linux/ghostty_nautilus.py to share/nautilus-python/extensions/com.mitchellh.ghostty.py success
+- install images/icons/icon_16.png to share/icons/hicolor/16x16/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_32.png to share/icons/hicolor/32x32/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_128.png to share/icons/hicolor/128x128/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_256.png to share/icons/hicolor/256x256/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_512.png to share/icons/hicolor/512x512/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_1024.png to share/icons/hicolor/1024x1024/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_16@2x.png to share/icons/hicolor/16x16@2/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_32@2x.png to share/icons/hicolor/32x32@2/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_128@2x.png to share/icons/hicolor/128x128@2/apps/com.mitchellh.ghostty.png success
+- install images/icons/icon_256@2x.png to share/icons/hicolor/256x256@2/apps/com.mitchellh.ghostty.png success
dpkg-deb: building package 'ghostty' in 'ghostty_1.1.0-0~ppa1_amd64.deb'.

@mkasberg
Copy link
Owner Author

mkasberg commented Feb 1, 2025

This PR shows the error we're running into, I haven't had time to look at it in depth yet: #59

@fdellwing
Copy link

fdellwing commented Feb 1, 2025 •
edited
Loading

I have seen the error, I'm just unable to reproduce it outside of the GitHub runner.

Is that some kind of cache problem? Does it happen if only 22.04. is build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkasberg @fdellwing