Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid 'Expires' makes response stale #68

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Invalid 'Expires' makes response stale #68

merged 2 commits into from
Feb 13, 2024

Conversation

mizosoft
Copy link
Owner

This wasn't guaranteed previously as an invalid Expires would've caused the cache to fall back to heuristic freshness, which might've made the response fresh & hence serveable.

Closes #64

@coveralls
Copy link

coveralls commented Feb 13, 2024

Coverage Status

coverage: 91.373% (+0.07%) from 91.299%
when pulling cca9824 on invalid-expires
into 1e8e640 on master.

@mizosoft mizosoft merged commit 637db07 into master Feb 13, 2024
13 of 17 checks passed
@mizosoft mizosoft deleted the invalid-expires branch February 13, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't parse HTTP date
2 participants