Optix 8 abi bump #1480
Open
Optix 8 abi bump #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would submit them all even if the pipeline only used a subset of them. In theory, that should not matter. However, OptiX 8.0 flags that as a potential issue when the validation layer is enabled.
This commit also update the `resources/data` submodule which holds the references for the OptiX denoiser tests
|
Hi @njroussel, Does this API bump change the minimum supported driver version? (Just to make sure that it is documented and checked at runtime). |
There is an error message in Dr.Jit-Core when OptiX is first used. But the Mitsuba documentation likely needs an update. |
|
This looks great. For posterity, can you explain the simplification?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of a series to upgrade to OptiX 8.0:
It introduces the following changes:
OptixDenoiserinterfaceresources/datasubmodule must be updated prior to merging this PR.Testing
No new tests were added. Tests for
OptixDenoiserwere updated due to the new interface.