Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed integrator render functions to take UInt32 for seed #1350

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

DoeringChristian
Copy link
Contributor

@DoeringChristian DoeringChristian commented Oct 21, 2024

Description

The PR expands on Change seed function to take drjit type for seed, by changing the render, render_forward and render_backward signatures to take a UInt32 for the seed argument as well.
This is necessary for function freezing, to allow changing the seed between calls to a frozen function without having to re-trace it.

Testing

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • My code also compiles for cuda_* and llvm_* variants. If you can't test this, please leave below
  • I have commented my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I cleaned the commit history and removed any "Merge" commits
  • I give permission that the Mitsuba 3 project may redistribute my contributions under the terms of its license

@DoeringChristian DoeringChristian marked this pull request as ready for review October 25, 2024 08:18
@merlinND
Copy link
Member

Hi @DoeringChristian,

Could you please rebase this PR, let's check if the CI is still green, and then I think it should be okay to merge.

@DoeringChristian
Copy link
Contributor Author

Let me check, this PR might be included in the frozen-functions one. Might be easier to merge it in one go.

@merlinND
Copy link
Member

Personally I like having a smaller PR just for this change, especially given that the other PRs are huge. (Assuming that this PR is works correctly on its own).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@wjakob
Copy link
Member

wjakob commented Feb 14, 2025

Thanks @DoeringChristian, I'll merge this PR without further review since the changes seem rather harmless.

@wjakob wjakob merged commit 4398d85 into mitsuba-renderer:master Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants