Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handler signature to address websocket errors #3134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

uruwhy
Copy link
Contributor

@uruwhy uruwhy commented Feb 20, 2025

Description

Address websocket errors in #3121 caused by incorrect handler function signatures.

Update required websockets version to 15.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran with response plugin to verify at least one websocket handler was triggered. Also confirmed error message stopped appearing on server startup.

Tested with Python 3.12.3 and websockets v15

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@uruwhy uruwhy marked this pull request as ready for review February 21, 2025 16:19
@uruwhy uruwhy requested a review from elegantmoose as a code owner February 21, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant