ci: add MSYS2 jobs #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umarcor
force-pushed
the
ci/msys2
branch
9 times, most recently
from
8da49dd to
48a46f5
Compare
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5
In this PR, two MSYS2 jobs are added: MINGW32 and MINGW64.
Currently, both of them fail because the build script seems not to download the Windows binaries: https://github.com/umarcor/make-env/runs/1370466660?check_suite_focus=true#step:5:9. MINGW terminals are bash shells but do use windows binaries. Therefore, the usage of
OS_TYPEin https://github.com/SymbiFlow/make-env/blob/master/os.mk falls short. IMHO,SHELL_TYPEneeds to be defined too, andOS_TYPEfor MINGW should beWindows. I'm not sure about the OS type for cygwin/MSYS.