Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add strict typing #16

Merged
merged 6 commits into from
Dec 28, 2024
Merged

feat: add strict typing #16

merged 6 commits into from
Dec 28, 2024

Conversation

pkucmus
Copy link
Collaborator

@pkucmus pkucmus commented Dec 19, 2024

No description provided.

@pkucmus pkucmus requested a review from Minister944 December 20, 2024 08:30
Minister944
Minister944 approved these changes Dec 21, 2024
View reviewed changes
Copy link

@Minister944 Minister944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should require some version

dependencies = [
    "starlette",
    "uvicorn",
    "aws-lambda-powertools",
    "toml",
    "pydantic",
    "rich",
    "click",
    "asgiref",
    "typer",
    "setproctitle",
]

image

@pkucmus
Copy link
Collaborator Author

pkucmus commented Dec 22, 2024

I wonder if we should require some version

dependencies = [
    "starlette",
    "uvicorn",
    "aws-lambda-powertools",
    "toml",
    "pydantic",
    "rich",
    "click",
    "asgiref",
    "typer",
    "setproctitle",
]

We will for 1.0

@pkucmus pkucmus requested a review from Minister944 December 22, 2024 21:38
@pkucmus
Copy link
Collaborator Author

pkucmus commented Dec 22, 2024

@Minister944 please take a look again. I've added 281bae9, it might look like a lot but it's just env var handling.

@pkucmus
feat!: add the AWS Lambda environment variables and allow to overload…
cbd6add 
… them in config

BREAKING CHANGE: to allow access to more context, the event generator functions now take the the Starlette.Request, a SmythHandler instance and a RunnerProcessProtocol compatible type. Previously there was only the request
@pkucmus pkucmus merged commit 2bde2fe into main Dec 28, 2024
4 checks passed
@pkucmus pkucmus deleted the typing branch December 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minister944 Minister944 Awaiting requested review from Minister944

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkucmus @Minister944