fix sign error in early_stopping.py #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ESEberhard , thank you for spotting this and raising a PR! We have migrated towards using PyTorch Lightning (on the |
cw-tan
force-pushed
the
fix-early-stopping
branch
from
c6c9e5b to
66bdee2
Compare
Linux-cpp-lisp
approved these changes
Feb 14, 2025
|
Thanks for catching this @ESEberhard ! |
|
Thanks @ESEberhard, reopened to make sure that users using the pre-overhaul version of NequIP gets your fix. Will merge once the tests run successfully. |
Merged
cw-tan
force-pushed
the
fix-early-stopping
branch
from
66bdee2 to
8de03ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I greatly appreciated your paper :)
While working with your code, I think I found a small but nevertheless consequential typo in your early stopping procedure,
than kept my runs from finishing.