CRIMAPP-1534 no empty cells #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timpeat
commented
Jan 13, 2025
| @@ -1,4 +1,4 @@ | |||
| <%= govuk_service_navigation(navigation_id: 'example-5', current_path: request.path, classes: 'app-service-navigation') do |sn| %> | |||
| <%= govuk_service_navigation(current_path: request.path, classes: 'app-service-navigation') do |sn| %> | |||
There was a problem hiding this comment.
☝️ removes unrelated copy paste error spotted as part of this work.
timpeat
force-pushed
the
CRIMAPP-1534-no-empty-cells
branch
from
0e8ba13 to
6350981
Compare
There was a problem hiding this comment.
Looks like case type could be blank as well. Should we be handling empty cells in that column?
There was a problem hiding this comment.
Good call. Thanks @EdwinKruglov
EdwinKruglov
approved these changes
Jan 14, 2025
timpeat
force-pushed
the
CRIMAPP-1534-no-empty-cells
branch
from
f3db0b7 to
8e67f2d
Compare
timpeat
force-pushed
the
CRIMAPP-1534-no-empty-cells
branch
from
8e67f2d to
04889a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add visually hidden text to empty table cells.
Link to relevant ticket
CRIMAPP-1534
Notes for reviewer
As per accessibility recommendation, add visually hidden text in the format "No data exists for %{column_name}" to empty table cells.
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature