[CRIMAPP-1258] Add cifc reason to summary (#681)

* CRIMAPP-1258 Add cifc reason * Update schema * Remove extra line
ministryofjustice · Aug 14, 2024 · fe86aa8 · fe86aa8
1 parent 3f52722
commit fe86aa8
Show file tree

Hide file tree

Showing 6 changed files with 38 additions and 12 deletions.
diff --git a/Gemfile b/Gemfile
@@ -25,7 +25,7 @@ gem 'laa-criminal-applications-datastore-api-client',
 
 gem 'laa-criminal-legal-aid-schemas',
     github: 'ministryofjustice/laa-criminal-legal-aid-schemas',
-    tag: 'v1.2.1'
+    tag: 'v1.2.3'
 
 # The original asset pipeline for Rails [https://github.com/rails/sprockets-rails]
 gem 'sprockets-rails'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -9,10 +9,10 @@ GIT
 
 GIT
   remote: https://github.com/ministryofjustice/laa-criminal-legal-aid-schemas.git
-  revision: 1ae303e88d01904ab1439dea45c60dd644a20f7b
-  tag: v1.2.1
+  revision: 8448023bdd8cb46075a489beea781ce026690d61
+  tag: v1.2.3
   specs:
-    laa-criminal-legal-aid-schemas (1.2.1)
+    laa-criminal-legal-aid-schemas (1.2.3)
       dry-schema (~> 1.13)
       dry-struct (~> 1.6.0)
       json-schema (~> 4.0.0)

diff --git a/app/views/casework/crime_applications/_overview.html.erb b/app/views/casework/crime_applications/_overview.html.erb
@@ -10,15 +10,26 @@
     </div>
 
     <% if overview.cifc? %>
+      <div class="govuk-summary-list__row">
+        <dt class="govuk-summary-list__key">
+          <%= label_text(:pre_cifc_reason) %>
+        </dt>
+        <dd class="govuk-summary-list__value">
+          <span id="pre_cifc_reason">
+            <%= overview.pre_cifc_reason.presence || t(:not_provided, scope: 'values') %>
+          </span>
+        </dd>
+      </div>
+
       <% if overview.maat_id_selected? %>
         <div class="govuk-summary-list__row">
           <dt class="govuk-summary-list__key">
             <%= label_text(:pre_cifc_maat_id) %>
           </dt>
           <dd class="govuk-summary-list__value">
-        <span id="pre_cifc_maat_id">
-          <%= overview.pre_cifc_maat_id.presence || t(:not_provided, scope: 'values') %>
-        </span>
+            <span id="pre_cifc_maat_id">
+              <%= overview.pre_cifc_maat_id.presence || t(:not_provided, scope: 'values') %>
+            </span>
           </dd>
         </div>
       <% elsif overview.usn_selected? %>
@@ -27,9 +38,9 @@
             <%= label_text(:pre_cifc_usn) %>
           </dt>
           <dd class="govuk-summary-list__value">
-        <span id="pre_cifc_usn">
-          <%= overview.pre_cifc_usn.presence || t(:not_provided, scope: 'values') %>
-        </span>
+            <span id="pre_cifc_usn">
+              <%= overview.pre_cifc_usn.presence || t(:not_provided, scope: 'values') %>
+            </span>
           </dd>
         </div>
       <% end %>

diff --git a/config/locales/en/casework.yml b/config/locales/en/casework.yml
@@ -376,6 +376,7 @@ en:
     no_partner_declaration_reason: Reason for no partner declaration
     pre_cifc_maat_id: MAAT ID of original application
     pre_cifc_usn: USN of original application
+    pre_cifc_reason: Changes in client's financial circumstances
 
   table_headings: &TABLE_HEADINGS
     applicant_name: Applicant's name

diff --git a/spec/presenters/outgoing_payments_presenter_spec.rb b/spec/presenters/outgoing_payments_presenter_spec.rb
@@ -11,9 +11,9 @@
 
     # rubocop:disable Layout/LineLength
     it {
-      expect(formatted_outgoing_payments).to include({ 'childcare' => be_a(LaaCrimeSchemas::Structs::OutgoingsDetails::Outgoing),
+      expect(formatted_outgoing_payments).to include({ 'childcare' => be_a(LaaCrimeSchemas::Structs::Outgoing),
                                                      'maintenance' => nil,
-                                                     'legal_aid_contribution' => be_a(LaaCrimeSchemas::Structs::OutgoingsDetails::Outgoing) })
+                                                     'legal_aid_contribution' => be_a(LaaCrimeSchemas::Structs::Outgoing) })
     }
     # rubocop:enable Layout/LineLength
 

diff --git a/spec/system/casework/viewing_an_application/that_is_open_and_unassigned_spec.rb b/spec/system/casework/viewing_an_application/that_is_open_and_unassigned_spec.rb
@@ -32,6 +32,20 @@
   end
 
   context 'when application_type is `change_in_financial_circumstances`' do
+    context 'with reason provided' do
+      let(:application_data) do
+        super().deep_merge(
+          'application_type' => 'change_in_financial_circumstances',
+          'pre_cifc_reason' => 'Won the lottery'
+        )
+      end
+
+      it 'displays reason' do
+        expect(page).to have_content("Changes in client's financial circumstances")
+        expect(page).to have_content('Won the lottery')
+      end
+    end
+
     context 'with USN provided' do
       let(:application_data) do
         super().deep_merge(