Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved logging and defer batch_id generation until later #9

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Improved logging and defer batch_id generation until later #9

merged 1 commit into from
Jan 15, 2025

Conversation

dconneely
Copy link
Collaborator

  • Improved logging and defer batch_id generation until later

@dconneely dconneely marked this pull request as ready for review January 15, 2025 15:02
@dconneely dconneely requested a review from a team as a code owner January 15, 2025 15:02
LAA-Dave-Edwards
LAA-Dave-Edwards approved these changes Jan 15, 2025
View reviewed changes
Copy link

@LAA-Dave-Edwards LAA-Dave-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Renumbering should lower the maat intensity for sure :)

@dconneely dconneely merged commit c86c109 into main Jan 15, 2025
1 check passed
@dconneely dconneely deleted the add-better-logging-batching branch January 15, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LAA-Dave-Edwards LAA-Dave-Edwards LAA-Dave-Edwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconneely @LAA-Dave-Edwards