Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run small tests with appropriate batching #8

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dconneely
Copy link
Collaborator

No description provided.

@dconneely dconneely marked this pull request as ready for review January 13, 2025 22:45
@dconneely dconneely requested a review from a team as a code owner January 13, 2025 22:45
@@ -36,7 +38,7 @@ WHERE rep_id IN (:maatIds)
final long fdcId = rs.getLong(1);
final long maatId = rs.getLong(2);
set.remove(maatId);
return CaseMigration.ofFdcContribution(maatId, fdcId, (long) rowNum);
return CaseMigration.ofFdcContribution(maatId, fdcId, (batchIndex[0]++) / INTDB_BATCH_ID_DIVISOR);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

Copy link

@LAA-Dave-Edwards LAA-Dave-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dconneely dconneely merged commit b634dfa into main Jan 14, 2025
1 check passed
@dconneely dconneely deleted the add-test-batching branch January 14, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants