[CRIMAPP-1513] Metabase metadata update #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds attributes to metadata json to fix filtering issue in metabase
Metabase restricts the number of filter fields for nested json, see warning message:
WARN metabase.driver.sql-jdbc.sync.describe-table More nested field columns detected than maximum. Limiting the number of nested field columns to 100.The
submitted_applicationjson has exceeded this limit. This meant fields that were previously available to use on metabase to create new reports or filter existing reports were missing or no longer workingAs the metadata json is under the limit of 100, making filters of interested available on the metadata should make it possible to filter on those attributes added
Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMAPP-1513
Notes for reviewer / how to test