Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIMAPP-449] Redact additional information #212

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

hiboabd
Copy link
Contributor

@hiboabd hiboabd commented Feb 5, 2024

Description of change

Redacts additional_information text ahead of feature release

Link to relevant ticket

CRIMAPP-449

Notes for reviewer / how to test

Submit an application with additional information. Open a datastore console and retrieve the submitted application and its redacted record. JSON for additional information should look similar to this:

"additional_information"=>"__redacted__"

@hiboabd hiboabd marked this pull request as ready for review February 5, 2024 12:32
@hiboabd hiboabd requested a review from a team as a code owner February 5, 2024 12:32
Copy link
Member

@timpeat timpeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)


next if details.blank?
next if payload_details.blank?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name 👍

@hiboabd hiboabd merged commit 143e74e into main Feb 5, 2024
6 checks passed
@hiboabd hiboabd deleted the CRIMAPP-449-anonymise-additional-information branch February 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants