generated from ministryofjustice/hmpps-template-typescript
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable searching for an applicant via CRN #71
Draft
libuk
wants to merge
12
commits into
main
Choose a base branch
from
CBA-111-search-by-crn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
230fce2
to
9f5808f
Compare
3b35c63
to
cc9438d
Compare
3802ee1
to
d84aff7
Compare
a733da2
to
f8f6c65
Compare
6c65e61
to
a041ef7
Compare
We want to allow court referrers to search for an applicant using a CRN.
As we are introducing the ability to search by CRN, we want the default find action in the PeopleController to be more specific to finding an applicant via prison number.
We want the ability to search for applicants via CRN. This commit adds a new method to the person client to achieve such. We also rename the existing method to be specific to searching with a prison number.
We want the ability to find applicants via CRN. This commit adds a new method to the person service to achieve such. We also rename the existing method to be specific to finding with a prison number.
We want the ability to find applicants via CRN. This commit adds a new method to the people controller to achieve such. We also rename the existing method to be specific to finding with a prison number.
We'll only allow Probation users to create court bail applications. This commit checks for the Probation user role and redirects the user if they are not authorised.
We want to be able to run out e2e tests as a BIO, this commit adds these login details to our pplaywright config.
We want to add a test for applying as a BIO and run this test after applying as a POM. In this commit we rename the assess and report tests to run 3rd and 4th respectively.
a041ef7
to
293551d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Context
We want to allow users to create an application for Court Bail.
Changes in this PR
ROLE_PROBATION
from seeing the search by CRN screenScreenshots of UI changes
Users with
ROLE_PROBATION
Users without
ROLE_PROBATION
Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to
main
we must firstconfirm:
Pre merge checklist
auditEvent
? (seeserver/routes/apply.ts
for examples)Post merge
Once we've merged it will be auto-deployed to the dev environment.