Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable searching for an applicant via CRN #71

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

libuk
Copy link
Contributor

@libuk libuk commented Jan 28, 2025

JIRA

Context

We want to allow users to create an application for Court Bail.

Changes in this PR

  • Add screen for searching for an applicant via CRN
  • Restrict users without ROLE_PROBATION from seeing the search by CRN screen

Screenshots of UI changes

Users with ROLE_PROBATION

Screenshot 2025-01-30 at 15 49 10

Users without ROLE_PROBATION

Screenshot 2025-01-30 at 15 44 58

Release checklist

As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to main we must first
confirm:

Pre merge checklist

  • Are any changes required to the e2e tests?
  • If you've added a new route, have you added a new
    auditEvent? (see server/routes/apply.ts for examples)
  • Are there environment variables or other infrastructure configuration which needs to be included in this release?
  • Are there any data migrations required. Automatic or manual?
  • Does this rely on changes being deployed to the CAS API?

Post merge

Once we've merged it will be auto-deployed to the dev environment.

@libuk libuk force-pushed the CBA-111-search-by-crn branch 3 times, most recently from 230fce2 to 9f5808f Compare January 30, 2025 14:41
@libuk libuk changed the title Cba 111 search by crn Enable searching for an applicant via CRN Jan 30, 2025
@libuk libuk force-pushed the CBA-111-search-by-crn branch 3 times, most recently from 3b35c63 to cc9438d Compare January 30, 2025 16:30
@patrickjfl patrickjfl force-pushed the CBA-111-search-by-crn branch 2 times, most recently from 3802ee1 to d84aff7 Compare January 31, 2025 15:59
@libuk libuk force-pushed the CBA-111-search-by-crn branch 2 times, most recently from a733da2 to f8f6c65 Compare February 10, 2025 09:22
@libuk libuk force-pushed the CBA-111-search-by-crn branch 2 times, most recently from 6c65e61 to a041ef7 Compare February 12, 2025 16:51
Daniel Liburd added 12 commits February 25, 2025 09:26
We want to allow court referrers to search for an applicant using a CRN.
As we are introducing the ability to search by CRN, we want the default
find action in the PeopleController to be more specific to finding an
applicant via prison number.
We want the ability to search for applicants via CRN. This commit adds a
new method to the person client to achieve such. We also rename the
existing method to be specific to searching with a prison number.
We want the ability to find applicants via CRN. This commit adds a new
method to the person service to achieve such. We also rename the
existing method to be specific to finding with a prison number.
We want the ability to find applicants via CRN. This commit adds a new
method to the people controller to achieve such. We also rename the
existing method to be specific to finding with a prison number.
We'll only allow Probation users to create court bail applications. This
commit checks for the Probation user role and redirects the user if they
are not authorised.
We want to be able to run out e2e tests as a BIO, this commit adds these
login details to our pplaywright config.
We want to add a test for applying as a BIO and run this test after
applying as a POM. In this commit we rename the assess and report tests
to run 3rd and 4th respectively.
@libuk libuk force-pushed the CBA-111-search-by-crn branch from a041ef7 to 293551d Compare February 25, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant