Update funding and ID pages #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libuk
force-pushed
the
CBA-205-funding-cas2-accommodation-page
branch
9 times, most recently
from
9035454 to
793e2b9
Compare
libuk
changed the title
libuk
force-pushed
the
CBA-205-funding-cas2-accommodation-page
branch
8 times, most recently
from
be56409 to
2e88e7f
Compare
libuk
commented
Feb 20, 2025
assets/scss/application.scss
Outdated
| @@ -34,3 +34,8 @@ $govuk-page-width: $moj-page-width; | |||
| margin-bottom: govuk-spacing(3); | |||
| } | |||
| } | |||
|
|
|||
| .blue-border { | |||
There was a problem hiding this comment.
@patrickjfl I can remove this and use your newly created class once it's in.
patrickjfl
approved these changes
Feb 20, 2025
server/form-pages/apply/area-and-funding/funding-information/alternativeID.ts
Show resolved
Hide resolved
server/form-pages/apply/area-and-funding/funding-information/alternativeID.test.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+50
to
+53
| // And I am on the alternative applicant ID page | ||
| // -------------------------------- | ||
| AlternativeApplicantIdPage.visit(this.application) | ||
| }) |
There was a problem hiding this comment.
I think we want a Page.verifyOnPage() here
There was a problem hiding this comment.
@patrickjfl Hmm, is this required if we call verifyOnPage in the tests that follow? Maybe the comment should read something like "And I visit the alternative applicant ID page".
Comment on lines
+56
to
+59
| // And I am on the applicant ID page | ||
| // -------------------------------- | ||
| ApplicantIdPage.visit(this.application) | ||
| }) |
...s/tests/apply/area-and-funding/funding-information/complete_funding_cas2_accommodation.cy.ts
Outdated
Show resolved
Hide resolved
libuk
force-pushed
the
CBA-205-funding-cas2-accommodation-page
branch
from
2e88e7f to
8504b32
Compare
added 7 commits
February 20, 2025 17:01
The funding information page will now be updated to include questions regarding national insurance, benefits and education.
The page is now called funding cas2 accommodation and contains national insurance question which will be removed in a follow up commit.
As the national insurance question is now included in the FundingCas2Accommodation form page, we can remove the NI page.
* Change the path to 'applicant-id' * Update the checkbox text and hints
* Rename path to "alternative-applicant-id" * Update error message
libuk
force-pushed
the
CBA-205-funding-cas2-accommodation-page
branch
from
8504b32 to
f80cca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The funding information page will now be updated to include questions regarding national insurance, benefits and education.
Context
Changes in this PR
Screenshots of UI changes
Funding source page - before
Funding source page - after
ID page - before
ID page - after
Alternative ID page - before
Alternative ID page - after
Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to
mainwe must firstconfirm:
Pre merge checklist
auditEvent? (seeserver/routes/apply.tsfor examples)Post merge
Once we've merged it will be auto-deployed to the dev environment.