Skip to content

Commit

Permalink
wip - e2e test fix
Browse files Browse the repository at this point in the history
wip - e2e test fix
  • Loading branch information
Patrick Fleming committed Jan 31, 2025
1 parent cc9438d commit d84aff7
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 8 deletions.
5 changes: 3 additions & 2 deletions e2e-tests/steps/apply.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
completeBailConditionsAndSupportSessionsTask,
completeBailHearingInformationTask,
} from './bailInformationSection'
import { FindByCrnPage } from '../pages/apply/findByCrnPage'

export const startAnApplication = async (page: Page) => {
// Start page
Expand Down Expand Up @@ -151,9 +152,9 @@ export const viewApplicationMadeByAnotherUser = async (page: Page, name: string)
await expect(page.locator('h2').first()).toContainText('Application history')
}

export const createAnInProgressApplication = async (page: Page, person: TestOptions['person']) => {
export const createAnInProgressApplication = async (page: Page, person: TestOptions['person'], applicationOrigin: 'courtBail' | 'prisonBail') => {

Check failure on line 155 in e2e-tests/steps/apply.ts

View workflow job for this annotation

GitHub Actions / node build / Run the node build

Replace `page:·Page,·person:·TestOptions['person'],·applicationOrigin:·'courtBail'·|·'prisonBail'` with `⏎··page:·Page,⏎··person:·TestOptions['person'],⏎··applicationOrigin:·'courtBail'·|·'prisonBail',⏎`
await startAnApplication(page)
await selectApplicationOrigin(page)
await selectApplicationOrigin(page, applicationOrigin)
await enterPrisonerNumber(page, person.nomsNumber)
await confirmApplicant(page)
}
8 changes: 8 additions & 0 deletions e2e-tests/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ export const test = base.extend<TestOptions>({
},
{ option: true },
],
bioUser: [
{
name: 'CAS2 BIO user',
username: process.env.CAS2_BIO_USERNAME as string,
password: process.env.CAS2_BIO_PASSWORD as string,
},
{ option: true },
],
lcaUser: [
{
name: 'Licence Case-admin',
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/tests/01_apply_as_pom.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ test('add a note to a submitted application', async ({ page, person, pomUser })

test('cancel an in progress application from the task list', async ({ page, pomUser, person }) => {
await signIn(page, pomUser)
await createAnInProgressApplication(page, person)
await createAnInProgressApplication(page, person, 'prisonBail')
await viewInProgressDashboard(page)
const numberOfApplicationsBeforeCancellation = (await page.locator('tr').all()).length
await clickCancel(page, person.name)
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/tests/02_apply_as_bio.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ test('add a note to a submitted application', async ({ page, person, bioUser })

test('cancel an in progress application from the task list', async ({ page, bioUser, person }) => {
await signIn(page, bioUser)
await createAnInProgressApplication(page, person)
await createAnInProgressApplication(page, person, 'courtBail')
await viewInProgressDashboard(page)
const numberOfApplicationsBeforeCancellation = (await page.locator('tr').all()).length
await clickCancel(page, person.name)
Expand Down
8 changes: 4 additions & 4 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ export default defineConfig<TestOptions>({
},
bioUser: {
name: 'CAS2 Bail BIO User',
username: 'AP_USER_TEST_1',
password: 'password123456'
username: 'JIMSNOWLDAP',
password: 'secret'
}
},
},
Expand Down Expand Up @@ -104,8 +104,8 @@ export default defineConfig<TestOptions>({
},
bioUser: {
name: 'CAS2 Bail BIO User',
username: 'AP_USER_TEST_1',
password: 'password123456'
username: 'JIMSNOWLDAP',
password: 'secret'
}
},
dependencies: ['setupLocal'],
Expand Down

0 comments on commit d84aff7

Please sign in to comment.