Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1009: Add new icons of azure monitor #1024

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Issue 1009: Add new icons of azure monitor #1024

merged 6 commits into from
Oct 4, 2024

Conversation

tvqphuoc01
Copy link
Collaborator

@tvqphuoc01 tvqphuoc01 commented Oct 1, 2024 •
edited
Loading

  1. Add new icons for Azure Monitor

@tvqphuoc01 tvqphuoc01 marked this pull request as ready for review October 1, 2024 17:13
@tvqphuoc01 tvqphuoc01 self-assigned this Oct 1, 2024
@tvqphuoc01 tvqphuoc01 added the area/provider/azure Azure provider label Oct 1, 2024
@tvqphuoc01 tvqphuoc01 linked an issue Oct 1, 2024 that may be closed by this pull request
Feature request: New icons for Azure #1009
Closed
@filipeaaoliveira
Copy link
Collaborator

Hi @tvqphuoc01

I think the ideia of a local dev environment is good, however, to reduce the number of steps and to make it equal to everyone, we could implement Dev Containers.

The rest, looks good to me.

@tvqphuoc01
Copy link
Collaborator Author

Hi @tvqphuoc01

I think the ideia of a local dev environment is good, however, to reduce the number of steps and to make it equal to everyone, we could implement Dev Containers.

The rest, looks good to me.

Sure, I will update it thank you 🤙

gabriel-tessier
gabriel-tessier approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filipeaaoliveira filipeaaoliveira merged commit 2aed805 into master Oct 4, 2024
5 checks passed
@filipeaaoliveira filipeaaoliveira deleted the issue-1009-add-new-icons-of-azure-monitor branch October 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-tessier gabriel-tessier gabriel-tessier approved these changes

@mingrammer mingrammer Awaiting requested review from mingrammer

@filipeaaoliveira filipeaaoliveira Awaiting requested review from filipeaaoliveira

Assignees

@tvqphuoc01 tvqphuoc01

Labels
area/provider/azure Azure provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: New icons for Azure
3 participants
@tvqphuoc01 @filipeaaoliveira @gabriel-tessier