Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO SQUASH] Enable luacheck & add choppy group to sliding doors #33

Merged
merged 2 commits into from
Dec 27, 2023
Merged

[NO SQUASH] Enable luacheck & add choppy group to sliding doors #33

merged 2 commits into from
Dec 27, 2023
+46 −42

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Dec 10, 2023

  • Enable luacheck (fix warnings, add gh action, redo luacheckrc)
  • Add choppy group to (wodden) sliding doors

@Niklp09 Niklp09 changed the title [NO SQUASH] Enable luacheck & add choppy group so sliding doors [NO SQUASH] Enable luacheck & add choppy group to sliding doors Dec 10, 2023
SmallJoker
SmallJoker approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Will merge in a few days unless there are objections.

@SmallJoker SmallJoker merged commit 55cc1b0 into master Dec 27, 2023
2 checks passed
@Niklp09 Niklp09 deleted the lc_groupfix branch December 27, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niklp09 @SmallJoker