Patch 4.4.1 (correct this time)

.gitignore

@@ -7,3 +7,6 @@ __pycache__
 # Do not keep tests and coverage results
 .pytest_cache
 .coverage
+
+# To avoid cluttering when switching branch with 'rust-rewrite' branch.
+/rust

portablemc/__init__.py

@@ -7,7 +7,7 @@
 """
 
 LAUNCHER_NAME = "portablemc"
-LAUNCHER_VERSION = "4.4.0"
+LAUNCHER_VERSION = "4.4.1"
 LAUNCHER_AUTHORS = ["Théo Rozier <contact@theorozier.fr>", "Contributors"]
 LAUNCHER_COPYRIGHT = "PortableMC  Copyright (C) 2021-2024  Théo Rozier"
 LAUNCHER_URL = "https://github.com/mindstorm38/portablemc"

portablemc/standard.py

@@ -643,6 +643,16 @@ def _resolve_libraries(self, watcher: Watcher) -> None:
                     if minecraft_arch_bits is not None:
                         spec.classifier = spec.classifier.replace("${arch}", str(minecraft_arch_bits))
 
+                # Changed in 4.3.1, rules are checked after natives
+                rules = library.get("rules")
+                if rules is not None:
+
+                    if not isinstance(rules, list):
+                        raise ValueError(f"metadata: /libraries/{library_idx}/rules must be a list")
+
+                    if not interpret_rule(rules, self._features, f"metadata: /libraries/{library_idx}/rules"):
+                        continue
+
                 # Create a wildcard copy of the spec without version, because we don't
                 # want to match against version, regardless of its version, a library
                 # should not be added twice.
@@ -656,16 +666,6 @@ def _resolve_libraries(self, watcher: Watcher) -> None:
                     continue
                 unique_specs.add(spec_wild)
 
-                # Changed in 4.3.1, rules are checked after natives
-                rules = library.get("rules")
-                if rules is not None:
-
-                    if not isinstance(rules, list):
-                        raise ValueError(f"metadata: /libraries/{library_idx}/rules must be a list")
-
-                    if not interpret_rule(rules, self._features, f"metadata: /libraries/{library_idx}/rules"):
-                        continue
-
                 lib_entry: Optional[DownloadEntry] = None
 
                 # Avoids ready downloading if a fix is being used, in such case we'll use

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "portablemc"
-version = "4.4.0"
+version = "4.4.1"
 description = "PortableMC is a module that provides both an API for development of your custom launcher and an executable script to run PortableMC CLI."
 authors = ["Théo Rozier <contact@theorozier.fr>"]
 license = "GPL-3.0-only"