Rust Rewrite #215
Draft
Rust Rewrite #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage ? 63.60%
=======================================
Files ? 20
Lines ? 3314
Branches ? 0
=======================================
Hits ? 2108
Misses ? 1206
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mindstorm38
force-pushed
the
rust-rewrite
branch
from
b4826aa to
abd4ea8
Compare
mindstorm38
force-pushed
the
rust-rewrite
branch
from
c267d46 to
cad6e0d
Compare
mindstorm38
force-pushed
the
rust-rewrite
branch
from
067d590 to
2a5ac68
Compare
…f Windows with the default behavior on Linux
…rom the end user from messing with tokio-in-tokio issues.
mindstorm38
force-pushed
the
rust-rewrite
branch
from
5b327db to
e9bc302
Compare
…rigin, all unexpected errors must have an origin attached.
…orge version checking.
… serde modules, which have proven to be highly unstable.
…he name in the workspace.
|
I've created a C API crate, mainly as a placeholder for now. If someone wants to work on it, and mainly on the C header for now, feel free, I'll not work on this before finishing the CLI, so feel free to completly change it and propose your own view of it, I'm curious because from my short try I didn't come with a good API imo. Poke @Ristovski 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking pull request for the work-in-progress Rust rewrite, this will take a long, long time!
If you want to give feedback on the concept, not the code, please go check #196.
Feel free to review the code!
TODO: