Version 4.1.0 #184
Merged
Version 4.1.0 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing their maven repository??
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
…opefully remains accepted by Cloudflare, and may also speed up other requests that were limited du to python default User-Agent (pure deduction).
…arching for NeoForge version for now.
|
I'm using portablemc as primary launcher so neoforge support would be great |
The CLI support will be stable in the next update! |
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
portablemc/forge.py
Outdated
| """ | ||
| try: | ||
| # NOTE: For now we don't sanitize the parameter. | ||
| url = f"https://maven.neoforged.net/api/maven/latest/version/releases/net%2Fneoforged%2Fforge?filter={game_version}" |
There was a problem hiding this comment.
TODO: Sanitize this parameter
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
mindstorm38
commented
Nov 9, 2023
|
@mindstorm38 I think neoforge:1.20.1-latest (or other version) not working |
|
Remove the -latest, it's not needed for neoforge since there no latest/recommended distinction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ForgeVersion(Neoforged repo for ForgeVersion #180, thanks @MisileLab)portablemc/<version>neoforge:id and associated--neoforge-prefixargument (Neoforged repo for ForgeVersion #180)--loginargument when using thjelogincommand (Invalid session #182, thanks @superniels09)