Merge pull request #4 from xandkar/sk/disable-prints

Disable surprise prints in library code, but leave them in test code
mindeng · Jul 10, 2024 · 9b7fdf7 · 9b7fdf7
2 parents 5c4220e + 5af1524
commit 9b7fdf7
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "nom-exif"
-version = "1.2.0"
+version = "1.2.1"
 edition = "2021"
 license-file = "LICENSE"
 description = "Exif/metadata parsing library written in pure Rust, both JPEG/HEIF/HEIC images and MOV/MP4 videos are supported."

diff --git a/src/bbox.rs b/src/bbox.rs
@@ -339,7 +339,7 @@ mod tests {
 
         let mut boxes = Vec::new();
         let (remain, bbox) = travel_while(&meta.body_data()[4..], |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push(bbox.header.box_type.to_owned());
             bbox.box_type() != "iloc"
         })
@@ -362,7 +362,7 @@ mod tests {
         let mut boxes = Vec::new();
 
         let (remain, bbox) = travel_while(&buf, |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push((bbox.header.box_type.to_owned(), bbox.to_owned()));
             bbox.box_type() != "moov"
         })
@@ -381,7 +381,7 @@ mod tests {
 
         let mut boxes = Vec::new();
         let (remain, bbox) = travel_while(moov.body_data(), |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push(bbox.header.box_type.to_owned());
             bbox.box_type() != "meta"
         })
@@ -395,7 +395,7 @@ mod tests {
         let meta = bbox;
         let mut boxes = Vec::new();
         let (remain, _) = travel_while(meta.body_data(), |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push(bbox.header.box_type.to_owned());
             bbox.box_type() != "ilst"
         })
@@ -414,7 +414,7 @@ mod tests {
         let mut boxes = Vec::new();
 
         let (remain, bbox) = travel_while(&buf, |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push((bbox.header.box_type.to_owned(), bbox.to_owned()));
             bbox.box_type() != "moov"
         })
@@ -433,7 +433,7 @@ mod tests {
 
         let mut boxes = Vec::new();
         let (remain, bbox) = travel_while(moov.body_data(), |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push((bbox.header.box_type.to_owned(), bbox.to_owned()));
             bbox.box_type() != "udta"
         })
@@ -452,7 +452,7 @@ mod tests {
         let meta = bbox;
         let mut boxes = Vec::new();
         let (remain, _) = travel_while(meta.body_data(), |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push(bbox.header.box_type.to_owned());
             bbox.box_type() != "©xyz"
         })
@@ -464,7 +464,7 @@ mod tests {
 
         let mut boxes = Vec::new();
         let (remain, bbox) = travel_while(trak.body_data(), |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push(bbox.header.box_type.to_owned());
             bbox.box_type() != "mdia"
         })
@@ -477,7 +477,7 @@ mod tests {
         let mdia = bbox;
         let mut boxes = Vec::new();
         let (remain, _) = travel_while(mdia.body_data(), |bbox| {
-            println!("got {}", bbox.header.box_type);
+            // println!("got {}", bbox.header.box_type);
             boxes.push(bbox.header.box_type.to_owned());
             bbox.box_type() != "minf"
         })
@@ -504,7 +504,7 @@ mod tests {
 
         let (_, bbox) = find_box(&buf, "moov/udta/©xyz").unwrap();
         let bbox = bbox.unwrap();
-        println!("bbox: {:?}", bbox.header);
+        // println!("bbox: {:?}", bbox.header);
 
         // gps info
         assert_eq!(

diff --git a/src/bbox/iloc.rs b/src/bbox/iloc.rs
@@ -59,7 +59,7 @@ impl ParseBody<IlocBox> for IlocBox {
 
             let (remain, extent_count) = be_u16(remain)?;
             if extent_count > MAX_ILOC_EXTENTS_PER_ITEM {
-                eprintln!("extent_count: {extent_count}");
+                // eprintln!("extent_count: {extent_count}");
                 context("extent_count > 32", fail::<_, (), _>)(remain)?;
             }
 

diff --git a/src/bbox/ilst.rs b/src/bbox/ilst.rs
@@ -94,7 +94,7 @@ fn parse_value(type_code: u32, data: &[u8]) -> crate::Result<EntryValue> {
             8 => be_i64(data)?.1.into(),
             x => {
                 let msg = format!("Invalid ilst item data; data type is BE Signed Integer while data len is : {x}");
-                eprintln!("{msg}");
+                // eprintln!("{msg}");
                 return Err(msg.into());
             }
         },
@@ -106,15 +106,15 @@ fn parse_value(type_code: u32, data: &[u8]) -> crate::Result<EntryValue> {
             8 => be_u64(data)?.1.into(),
             x => {
                 let msg = format!("Invalid ilst item data; data type is BE Unsigned Integer while data len is : {x}");
-                eprintln!("{msg}");
+                // eprintln!("{msg}");
                 return Err(msg.into());
             }
         },
         23 => be_f32(data)?.1.into(),
         24 => be_f64(data)?.1.into(),
         o => {
             let msg = format!("Unsupported ilst item data type: {o}");
-            eprintln!("{msg}");
+            // eprintln!("{msg}");
             return Err(msg.into());
         }
     };