Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T 1377658: Updated Refresh Token API minimumExpirationTime to 6 minutes #170

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

AnshulMindbody
Copy link
Contributor

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Other

Summary

  • updated minimumExpirationTime to 6 minutes.

Implementation

  • It includes a change to the BearerToken struct in the Sources/Conduit/Auth/Models/OAuth2Token.swift file. The minimumExpirationTime for the isValid property has been reduced from 15 minutes to 5 minutes. This change affects how we determine the validity of the token.

Test Plan

  1. Test on all projects and verify refresh token API has been called 6 minutes before expiry.

Copy link

@rohitpradhan03 rohitpradhan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnshulMindbody AnshulMindbody merged commit 9182600 into main Nov 27, 2024
1 check passed
@AnshulMindbody AnshulMindbody deleted the Task/1377658-Update-minimum-expiration-time branch November 27, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants