Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add judgement for isPrimary #1745

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Oct 19, 2023

related: #1663

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn added this to the 2.3.2 milestone Oct 23, 2023
@sre-ci-robot sre-ci-robot merged commit 74ef426 into milvus-io:master Oct 23, 2023
8 checks passed
@hasansustcse13
Copy link

@MrPresent-Han

This issue is still persist as you don't check the key before access in query iterator but checked in search iterator.

QueryIterator:__setup__pk_prop
if field[IS_PRIMARY]:

SearchIterator:__setup__pk_prop
if IS_PRIMARY in field and field[IS_PRIMARY]:

Question: Can anyone tell me self.collection.query(expr=expression, output_fields=output_fields, **kwargs) return all the rows from DB if the collection has so many docs(more than 16384, assume 100000) if don't set any limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants