Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [skip e2e] update the collection detail page logic #39740

Merged

Conversation

mimoning
Copy link
Contributor

issue: #36621

issue: milvus-io#36621

Signed-off-by: mimo.oyn <ning.ouyang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 10, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mimoning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (ee87e4d) to head (33a40e5).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39740       +/-   ##
===========================================
+ Coverage   69.39%   80.14%   +10.75%     
===========================================
  Files         302     1476     +1174     
  Lines       27077   204377   +177300     
===========================================
+ Hits        18790   163807   +145017     
- Misses       8287    34722    +26435     
- Partials        0     5848     +5848     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core 69.39% <ø> (ø)
Go 81.88% <ø> (∅)

see 1174 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 10, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 10, 2025
issue: #36621

pr: #39740

Signed-off-by: mimo.oyn <ning.ouyang@zilliz.com>
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit ee716a5 into milvus-io:master Feb 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants