fix several bugs and add new parameter to support partition key. #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nianliuu
commented
Mar 7, 2024
nianliuu
commented
- fix bugs in describeIndex, make sure indexName matches the request
- add AddFieldReq to support add Field quickly
- support partition key and numPartition
- update queryResp and searchResp to sync with python
…request Signed-off-by: Nian Liu <nian.liu@zilliz.com>
… etc. Signed-off-by: Nian Liu <nian.liu@zilliz.com>
nianliuu
force-pushed
the
nianliu
branch
2 times, most recently
from
820efdc to
6d2caf5
Compare
…AddFieldReq, update QueryResp and SearchResp Signed-off-by: Nian Liu <nian.liu@zilliz.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nianliuu, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nianliuu
added a commit
that referenced
this pull request
Mar 8, 2024
* bug fix: check the fieldName and indexName matches the describeIndex request Signed-off-by: Nian Liu <nian.liu@zilliz.com> * add partitionKey support for collection create, add ShardsNum, Array, etc. Signed-off-by: Nian Liu <nian.liu@zilliz.com> * Feature sync: update createCollection to add several new params; add AddFieldReq, update QueryResp and SearchResp Signed-off-by: Nian Liu <nian.liu@zilliz.com> --------- Signed-off-by: Nian Liu <nian.liu@zilliz.com> (cherry picked from commit af62656)
nianliuu
added a commit
that referenced
this pull request
Mar 8, 2024
* bug fix: check the fieldName and indexName matches the describeIndex request Signed-off-by: Nian Liu <nian.liu@zilliz.com> * add partitionKey support for collection create, add ShardsNum, Array, etc. Signed-off-by: Nian Liu <nian.liu@zilliz.com> * Feature sync: update createCollection to add several new params; add AddFieldReq, update QueryResp and SearchResp Signed-off-by: Nian Liu <nian.liu@zilliz.com> --------- Signed-off-by: Nian Liu <nian.liu@zilliz.com> (cherry picked from commit af62656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.