-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Testcontainers Milvus module #783
Conversation
Welcome @eddumelendez! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉 |
MilvusMultiClientDockerTest can also be moved because Testcontainers also provide a minio module and etcd can be used using GenericContainer. |
Testcontainers 1.19.6 provides a milvus module. It uses an embedded etcd and local storage. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
36e4b16
to
bda5601
Compare
Hi @eddumelendez eddumelendez
|
@yhmo PR updated. I have excluded the dependencies to use the ones provided by milvus itself. Tests are running fine locally. |
Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
6d7bb58
to
43c2c24
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddumelendez, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With the testcontainers integrated, I ran the test case for the first time and encountered a timeout error that said the image testcontainers/ryuk:0.6.0 could not be pulled. Just note here for the people who may encounter this error in the future. |
* Use Testcontainers Milvus module Testcontainers 1.19.6 provides a milvus module. It uses an embedded etcd and local storage. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Polish pom Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
* Use Testcontainers Milvus module Testcontainers 1.19.6 provides a milvus module. It uses an embedded etcd and local storage. Signed-off-by: yhmo <yihua.mo@zilliz.com>
Testcontainers 1.19.6 provides a milvus module. It uses an embedded
etcd and local storage.