Making everything use a single structure #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the id and path of the output to match the way SpeedyWeather does it
Adding new runid
Matching the upstream repo
Just correcting the error with path versus outpath, restoring the name initpath in Parameters, all else the same
Matches the results from before changing the code
fixed that here
…/ShallowWaters.jl into add-new-integration
Removed redundant functions, fixed .gitignore
|
Also can you delete the |
|
With cd0cb6a I've just added Checkpointing.jl to extensions, do we need to do the same for Enzyme? Stupid me did that without a pull request, so I've switched on branch protection for main (requires a pull request and checks to pass) |
|
So you can add Checkpointing specific functions that should only load/overload when |
|
Did you mean to close this @swilliamson7 ? |
|
Yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've addressed all the comments from before, and that this code will run the same as your original code. If you could review the changes again when you have a moment that would be amazing! I've tried to double and triple check that everything will still run, but it's always possible I missed something. I think the other main change was to
output.jl, I find that the way I've adjusted it still works consistently (knock on wood) but I feel like I remember you finding times it would break?