Reformat odometer view #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelacaron
approved these changes
Oct 21, 2024
|
|
||
| var body: some View { | ||
| VStack(alignment: .leading, spacing: 8) { | ||
| Text("\(vehicleName ?? "No Name")").font(.title) |
There was a problem hiding this comment.
Let's use .title3, because just .title looks pretty big
also I personally like all modifiers to be on new lines, rather than on the same line so it'd look like:
Text("\(vehicleName ?? "No Name")")
.font(.title3)|
|
||
| import SwiftUI | ||
|
|
||
| struct ReadingView: View { |
There was a problem hiding this comment.
I'm going to rename this OdometerRowView, as opposed to ReadingView, to make it more clear
I fixed this
| await viewModel.deleteReading(reading) | ||
| let vehicleName = viewModel.vehicles.first { $0.id == reading.vehicleID }?.name | ||
| ReadingView(odometerReading: reading, vehicleName: vehicleName) | ||
| .listRowInsets(.init(top: 16, leading: 24, bottom: 16, trailing: 24)) |
There was a problem hiding this comment.
I think it's fine without these insets, I don't think it makes a dramatic difference
I fixed this
Comment on lines
12
to
18
| private let reading: OdometerReading | ||
| private let vehicleName: String? | ||
|
|
||
| init(odometerReading: OdometerReading, vehicleName: String?) { | ||
| self.reading = odometerReading | ||
| self.vehicleName = vehicleName | ||
| } |
There was a problem hiding this comment.
these variables don't need to be private, and by making them not private, we don't need to manually create an initializer
I fixed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does
OdometerView#336How I Tested
Notes
Screenshot