Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Display in settings #341

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

maartinj
Copy link
Contributor

What it Does

How I Tested

  • Run the application in Simulator (iPhone 15 Pro, iOS 17.5), set language to 'English'
  • Click tab 'Settings'
  • Click row 'Add Vehicle' in 'VEHICLES' section
  • Add information in NAME, MAKE, MODEL, YEAR, COLOR, VIN, LICENSE PLATE NUMBER section
  • Click 'Add' button
  • See the screen in 'Screenshot' section, where are displayed vehicle details in changed format

Notes

  • Changes in text also works when User will want to change vehicle details when vehicle details already exist

Screenshot

Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! I have several comments that need resolved please. If you have any questions, you can comment directly on that thread, otherwise click the resolve button once you've addressed my comment. Once you fix everything, please click the re-review button
Re-review button

and I was looking at the design, can we actually make the vehicle name the bolded words, as opposed to the make / model

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Need to integrate newer published changes with VehicleDisplayText branch
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@maartinj
Copy link
Contributor Author

Great work!! I have several comments that need resolved please. If you have any questions, you can comment directly on that thread, otherwise click the resolve button once you've addressed my comment. Once you fix everything, please click the re-review button Re-review button

and I was looking at the design, can we actually make the vehicle name the bolded words, as opposed to the make / model

Something like this?


I corrected PR with prefix v2 and above change about changing bolded words with new commit. Please check and let me know 👍

@maartinj maartinj requested a review from mikaelacaron October 15, 2024 17:06
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! Thanks for contributing!

VStack(alignment: .leading) {
Text(vehicle.name)
VStack(alignment: .leading, spacing: 2) {
Text("Display Name: \(vehicle.name)")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the word "Display Name" just using the name is fine

@mikaelacaron mikaelacaron merged commit 6e6a911 into mikaelacaron:dev Oct 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMPROVE -Vehicle Display in settings
2 participants