-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added app icons as a preview in ChooseAppIcon view #338
Added app icons as a preview in ChooseAppIcon view #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitaligondaliya good work! the app icons show on the ChooseAppIconView
, but it looks like this solution breaks the tinted and dark colored icons
is it possible to only add the IconPreviews folder, and not change the app icon types? (so it's only light, dark and tinted, as options rather than all the scale options)
and the icon previews, can we set the scale to "Single Scale"?
What do you mean by this? Are you referring to supporting dark and tinted icons? If so, we can add that. However, as I can see, we haven't supported that in the current app icon set. |
Yes we can set that. |
@mitaligondaliya can you clarify again, I'm kinda confused, why do we need to duplicate all of the app icon assets?? When the "Icon Previews" are all also 1024x1024? it looks like according to the code change, nothing is needed except using the |
@mikaelacaron From iOS 18 onward, alternate app icons are no longer directly accessible by SwiftUI views. If you want to display them within the app, they must be added separately as regular image assets in the asset catalog. |
How does the code know you're referencing the "Icon Previews" vs the app icon files? Cause it looks like regular app icons were added |
I've added the same icons because I don't have preview files available, but I can add them in the required size for icon previews and will change the name and code accordingly. |
what do you mean "preview files?" like the 64x64 size? Sorry I don't understand what needs to change vs what's in the PR right now? |
Yes, 64x64 size. We need to fix the app icon display issue, as it's currently not showing. The changes I've added should resolve this, and we also need the proper size preview icons, for which I'll ping you. |
@mikaelacaron I'm done with this fix. Kindly review it and let me know if any changes are needed. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for all the changes and explanations! great work!!
What it Does
How I Tested
For example:
Notes
Screenshot