Added privacy manifest info to PrivacyInfo files #320
Conversation
There was a problem hiding this comment.
Great work!! I have several comments that need resolved please. If you have any questions, you can comment directly on that thread, otherwise click the resolve button once you've addressed my comment. Once you fix everything, please click the re-review button
| @@ -90,7 +90,6 @@ | |||
| savedToolIdentifier = "" | |||
| useCustomWorkingDirectory = "NO" | |||
| debugDocumentVersioning = "YES" | |||
| askForAppToLaunch = "Yes" | |||
There was a problem hiding this comment.
you may need to manually add this back, it shouldn't be removed
There was a problem hiding this comment.
easiest way is to open in VSCode and add this back manually
Also you can just push new commits, the PR will update automatically
| @@ -8,5 +8,78 @@ | |||
| Copyright (c) 2024 Icy App Studio LLC. All rights reserved. | |||
| --> | |||
| <plist version="1.0"> | |||
| <dict/> | |||
| <dict> | |||
There was a problem hiding this comment.
Can you list in the PR description what privacy things you checked (like which bits are included)
And please add that to the AppStoreListing.md documentation file (make a new section called "Privacy Info"
There was a problem hiding this comment.
I was a little uncertain about adding a new section to the AppStoreListing.md file. After lots of googling I committed what I had done. If it's not right I can change it no problem.
…after it was removed by mistake.
| @@ -964,6 +964,7 @@ | |||
| CODE_SIGN_STYLE = Automatic; | |||
| DEAD_CODE_STRIPPING = YES; | |||
| DEVELOPMENT_ASSET_PATHS = "\"Basic-Car-Maintenance/Preview Content\""; | |||
| DEVELOPMENT_TEAM = ""; | |||
There was a problem hiding this comment.
you've selected development team and set it to none, but the correct way to fix this, is to manually go into the pbxproj file in like VSCode and delete the line that gets created (because without it, this will set everyone's team to none, rather than using the xcconfig file like it should)
What it Does
PrivacyInfo.xcprivacyfile #310 Create PrivacyInfo.xcprivacy fileUser Defaults APIs with usage reason CA92.1.
Name - linked to identity and app functionality.
Email Address - linked to identity and app functionality.
Phone number - linked to identity and app functionality.
Photos or videos - linked to identity.
User ID - linked to identity and app functionality.
How I Tested
NA
Notes
Used Privacymanifest.dev for XML template