Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont track inactive validators on rewards table #158

Open
santi1234567 opened this issue Feb 21, 2025 · 1 comment
Open

Dont track inactive validators on rewards table #158

santi1234567 opened this issue Feb 21, 2025 · 1 comment
Assignees

Comments

@santi1234567
Copy link
Member

santi1234567 commented Feb 21, 2025

Description

The t_validator_rewards_summary table is an essential part of goteth as it provides very useful information on rewards from validators and their performance. At the moment, the table stores data from all validators from the network (active and inactive). The only reason for this to make sense is because the rewards table tracks also balance, which is a metric that might be of interes from inactive validators.

The overhead on the disk usage of the rewards table just to store balance does not make sense and this should be looked into. At the moment of writing this, 41% of the validators on the network are inactive, meaning that ~41% of the disk usage of the table is pretty much useless. With the upcoming changes from EIP-7251, the % of inactive validators should increase significantly as validators start consolidating (see #153).

The proposal is to remove inactive validators from the table and potentially also add an optional balances table to track balance history if this is desired.

@santi1234567 santi1234567 self-assigned this Feb 21, 2025
@santi1234567 santi1234567 mentioned this issue Feb 21, 2025
14 tasks
@leobago
Copy link
Member

leobago commented Feb 24, 2025

Thanks for raising this issue Santi. Yes, tracking the balance of inactive validators is not the purpose of the rewards table, so we should remove them and save that unnecessary space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants